Skip to content

Conversation

victorjulien
Copy link
Member

It is unnecessary to always fetch the element as it is only needed when
there is a match. Get the list item only when the key candidate matches
the key parameter and the element needs to be returned. This will ensure
lesser calls to htp_list_get fn.
Copy link
Member

@inashivb inashivb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 22752

@victorjulien victorjulien merged commit 09d8110 into OISF:0.5.x Sep 20, 2024
5 checks passed
@victorjulien victorjulien deleted the next/579/20240919/v1 branch September 20, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants