Skip to content

Decompress end v3 #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Decompress end v3 #445

wants to merge 3 commits into from

Conversation

catenacyber
Copy link
Contributor

#444 with another commit

@catenacyber
decompressors: do not take data after end
1c07fe4
@catenacyber
response: end decompressors in chunked content
c713356 
When a response ends in the middle of a chunk, signal
it to the decompressors to let them finalize the data
they got so far, as is done with content-length.

Do this for all states of chunked content.
@catenacyber
chunks: abort asap on invalid chunk length
76884b5
@catenacyber catenacyber mentioned this pull request Mar 13, 2025
Closed
@suricata-qa
Copy link

ERROR:

ERROR: QA failed on SURI_TLPW1_files_sha256.

Pipeline 25097

@catenacyber
Copy link
Contributor Author

Still some new diffs with libhtp.rs v38
"4c535b8fcc24a9d9fea9462d9459569a87f74770ba9d2d271a63969c <
"ad7b67de4d9f271799b4845fcee1ec95956d105df7081039d09ceeb1 <
"e8fa2fdfe77bca682acc3a8def46f491b088f58dcb7599949aaa2eff <

seen here

and

							>       "16f0303324465ba9f44b981012a1ed3094d82650b753d5f6fb9b40d2
							>       "5bf6fda88e45ed8b1b37e1731c8a33a9160541e9513088f07b8f8850
							>       "6a17e25cd28428d099bb3249a909946b96023cf1d0ea0eeb5e6caf44
							>       "dc9daad4a8f638a67bdfa94ce12ca0fc4121f57d265a93a861720b41
							>       "e59696229cc023d0d11cbd4cb3b534c46c312a2c2f05f35baaf05c22

seen in libhtp.rs v38

@catenacyber
Copy link
Contributor Author

This passes UT+SV

@catenacyber
Copy link
Contributor Author

6a17e25cd28428d099bb3249a909946b96023cf1d0ea0eeb5e6caf4483021b25 and 4c2b36da6de0a59451666b8764e66fc222036a35186461cadb96e15a47c03c2b are different results for the same flow

@catenacyber catenacyber mentioned this pull request Mar 13, 2025
Closed
@catenacyber
Copy link
Contributor Author

Next in #446

@catenacyber catenacyber mentioned this pull request Mar 13, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@catenacyber @suricata-qa