Skip to content

Conversation

victorjulien
Copy link
Member

jufajardini and others added 7 commits March 14, 2025 06:54
When a response ends in the middle of a chunk, signal
it to the decompressors to let them finalize the data
they got so far, as is done with content-length.

Do this for all states of chunked content.
If a chunk length line was split in two packets, we buffered
the end of the first packet/beginning of the line, and checked
its validity.
So, do not check further on second packet.
Passing a gap to a decompressor closes it, but if we also finish
known content-length, we try to reclose decompressor and fail
@suricata-qa
Copy link

Information:

ERROR: QA failed on SURI_TLPW1_files_sha256.

field baseline test %
SURI_TLPW1_stats_chk
.app_layer.error.http.parser 47 45 95.74%
SURI_TLPR1_stats_chk
.app_layer.error.http.parser 574 536 93.38%

Pipeline 25120

Copy link
Contributor

@catenacyber catenacyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Staging is good

@jasonish jasonish merged commit 437f757 into OISF:0.5.x Mar 14, 2025
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants