Skip to content

Iprep compatibility #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Iprep compatibility #241

wants to merge 5 commits into from

Conversation

michaelschem
Copy link
Contributor

Make sure these boxes are signed before submitting your Pull Request
-- thank you.

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/3721

Describe changes:

  • adding IP Rep compatibility

@michaelschem michaelschem requested a review from jasonish as a code owner July 14, 2020 19:37
inashivb
inashivb requested changes Aug 29, 2020
View reviewed changes
Copy link
Member

@inashivb inashivb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @michaelschem !
Thanks for your contribution!
Could you please clean the commit history, write a descriptive commit message about what your PR does and re-submit? We'll be happy to take a look a look at it.

@michaelschem
Copy link
Contributor Author

Absolutely. I'll get it cleaned up soon and resubmit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonish jasonish Awaiting requested review from jasonish jasonish is a code owner

@inashivb inashivb Awaiting requested review from inashivb

Assignees
No one assigned
Labels
needs rebase
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelschem @inashivb @jasonish