transform/test: from_base64 tests using set_error #2212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests use the set_error transform option to signal buffers that cannot be base64-decoded. The absent keyword detects the signaling on a buffer that can't be decoded; absent with the or_else option is used when a buffer can be decoded.
jlucovsky
added
the
requires suricata fix
catenacyber
added
requires suricata pr
catenacyber
reviewed
Mar 5, 2025
| count: 1 | ||
| match: | ||
| event_type: alert | ||
| alert.signature_id: 6 |
There was a problem hiding this comment.
Why this test change ?
catenacyber
reviewed
Mar 5, 2025
| # input pcap contains a query to http://home.regit.org/?arg=dGhpc2lzYXRlc3QK | ||
| # "dGhpc2lzYXRlc3QK" is "thisisatest\n" | ||
| alert tcp any any -> any any (msg:"from_base64: no-decode [mode rfc4648]"; flow:to_server,established; http.uri; content:"/?arg="; from_base64: set_error; absent; sid:1; rev:1;) | ||
| alert tcp any any -> any any (msg:"from_base64: no-decode with or_else [mode rfc4648]"; flow:to_server,established; http.uri; content:"/?arg="; from_base64: set_error; absent: or_else; content: "foobar"; sid:2; rev:1;) |
There was a problem hiding this comment.
absent: or_else; content: "foobar"; looks strange to me, what did you mean ?
Did you mean absent: or_else; content: !"foobar"; ?
catenacyber
reviewed
Mar 5, 2025
| event_type: alert | ||
| alert.signature_id: 1 | ||
| - filter: | ||
| count: 0 |
There was a problem hiding this comment.
Why sid 1 matches and not sid 2 ?
I would expect sid 2 to match as well
catenacyber
reviewed
Mar 5, 2025
| # "dGhpc2lzYXRlc3QK" is "thisisatest\n" | ||
| alert tcp any any -> any any (msg:"from_base64: no-decode [mode rfc4648]"; flow:to_server,established; http.uri; content:"/?arg="; from_base64: set_error; absent; sid:1; rev:1;) | ||
| alert tcp any any -> any any (msg:"from_base64: no-decode with or_else [mode rfc4648]"; flow:to_server,established; http.uri; content:"/?arg="; from_base64: set_error; absent: or_else; content: "foobar"; sid:2; rev:1;) | ||
| alert http any any -> any any (msg:"from_base64: decode with or_else [mode rfc4648]"; http.uri; content:"/?arg=dGhpc2lzYXRlc3QK"; from_base64: offset 10; absent: or_else; content:"sisatest"; sid:3; rev:1;) |
There was a problem hiding this comment.
How could from_base64 without set_error match absent ?
This rule should be rejected as invalid...
catenacyber
requested changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests use the set_error transform option to signal buffers that cannot be base64-decoded.
The absent keyword detects the signaling on a buffer that can't be decoded; absent with the or_else option is used when a buffer can be decoded.
Ticket
If your pull request is related to a Suricata ticket, please provide
the full URL to the ticket here so this pull request can monitor
changes to the ticket status:
Redmine ticket: https://redmine.openinfosecfoundation.org/issues/7114