Skip to content

Conversation

victorjulien
Copy link
Member

No description provided.

@victorjulien victorjulien added the tests pass These new tests should pass label Mar 28, 2025
Copy link
Contributor

@jufajardini jufajardini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

Copy link
Member

@jasonish jasonish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK, but we have none of these unnsupported ones in here now..

@victorjulien
Copy link
Member Author

Looks OK, but we have none of these unnsupported ones in here now..

Triggered by #2339 failing in staging.

@catenacyber
Copy link
Collaborator

Thanks for adding this :-)

@catenacyber
Copy link
Collaborator

(I checked my new PRs, nut not the old ones)

@victorjulien victorjulien merged commit ad7ee81 into OISF:master Mar 29, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests pass These new tests should pass
Development

Successfully merging this pull request may close these issues.

4 participants