test/byte-vars: Restrict var usage to single-buffer #2576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlucovsky
added
the
requires suricata fix
Wonder where it comes from :-p |
catenacyber
added
requires suricata pr
This was referenced Jun 20, 2025
catenacyber
reviewed
Jun 25, 2025
catenacyber
reviewed
Jun 25, 2025
jlucovsky
force-pushed
the
1412/1
branch
2 times, most recently
from
c950a72 to
e58a07a
Compare
catenacyber
requested changes
Jul 2, 2025
There was a problem hiding this comment.
See decision in OISF/suricata#13516 (review) :
needs a warning, and only an error when in "strict" mode
So we need tests for these 2 modes
catenacyber
reviewed
Jul 3, 2025
tests/detect-bytemath-09/test.yaml
Outdated
| @@ -0,0 +1,13 @@ | |||
| requires: | |||
| min-version: 8 | |||
There was a problem hiding this comment.
Only the shell check requires min-version 8, right ?
catenacyber
reviewed
Jul 3, 2025
tests/detect-bytemath-05/test.yaml
Outdated
|
|
||
| requires: | ||
| min-version: 7 | ||
| version: 7 |
There was a problem hiding this comment.
Do we really need this change ?
This was referenced Aug 12, 2025
|
Is this PR up to date wrt the latest desiderata for the suricata PR ? |
catenacyber
reviewed
Aug 27, 2025
| count: 1 | ||
| match: | ||
| event_type: alert | ||
| alert.signature_id: 44412999 |
There was a problem hiding this comment.
I would like a README, or a comment here ;-)
This was referenced Sep 3, 2025
Add/modify test cases to use the `rule-strict-keywords` where appropriate. 2 new test cases - bytemath-07 Test 05 for release 8 and later - bytemath-08 Using additional "lol" signature - bytemath-09 Using additional "lol" signature Issue: 1412
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 new test cases
Issue: 1412
Ticket
If your pull request is related to a Suricata ticket, please provide
the full URL to the ticket here so this pull request can monitor
changes to the ticket status:
Redmine ticket: