Mime type reload #2606
Open
Mime type reload #2606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catenacyber
reviewed
Jul 22, 2025
| @@ -0,0 +1,19 @@ | |||
| requires: | |||
| features: | |||
| - HAVE_MIMETYPE | |||
There was a problem hiding this comment.
@jasonish seeing green CI for this highlights that we need SV coverage ;-)
There was a problem hiding this comment.
Please elaborate? What would this look like?
There was a problem hiding this comment.
You seemed to have more ideas than me.
I was just saying that manual runs should be done for releases to ensure that every SV test/check is run.
You were saying that there were tools to do that ;-)
There was a problem hiding this comment.
No tools that I know of. I think Victor put out a wish directed my way that tools exist, to which I had no comment :)
5 tasks
This was referenced Aug 5, 2025
5 tasks
catenacyber
reviewed
Aug 27, 2025
| count: 1 | ||
| match: | ||
| event_type: alert | ||
| alert.signature_id: 1338 |
There was a problem hiding this comment.
nit: we could check that the alert event has the mimetype
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for new mime type computation and match.
Redmine ticket: https://redmine.openinfosecfoundation.org/issues/7816