Skip to content

Conversation

jlucovsky
Copy link
Contributor

Continuation of #13509

Issue: 1412

Extend the checks added for 7549 to include buffers.

Only consider sig matches with compatible ids/lists.

Link to ticket: https://redmine.openinfosecfoundation.org/issues/1412

Describe changes:

  • Extend buffer/variable checks to buffers init data

Updates:

Provide values to any of the below to override the defaults.

  • To use a Suricata-Verify or Suricata-Update pull request,
    link to the pull request in the respective _BRANCH variable.
  • Leave unused overrides blank or remove.

SV_REPO=
SV_BRANCH=OISF/suricata-verify#2576
SU_REPO=
SU_BRANCH=

Issue: 1412

Extend the checks added for 7549 to include buffers.

Only consider sig matches with compatible ids/lists.
Issue 1412

Add mention of byte_{extract,math,test,jump} variable usage
and buffer scope.
Copy link

codecov bot commented Jun 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.49%. Comparing base (495a12f) to head (64f92dc).
Report is 43 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #13516   +/-   ##
=======================================
  Coverage   83.48%   83.49%           
=======================================
  Files        1011     1011           
  Lines      274902   274908    +6     
=======================================
+ Hits       229507   229523   +16     
+ Misses      45395    45385   -10     
Flag Coverage Δ
fuzzcorpus 61.78% <100.00%> (+0.01%) ⬆️
livemode 18.95% <0.00%> (-0.01%) ⬇️
pcap 44.64% <52.17%> (-0.03%) ⬇️
suricata-verify 65.03% <100.00%> (+<0.01%) ⬆️
unittests 59.14% <60.86%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline = 26586

@catenacyber catenacyber added the decision-required Waiting on deliberation from the team label Jun 25, 2025
@catenacyber
Copy link
Contributor

I think we need to think about the expected behavior here (see SV test comment)

Copy link
Contributor

@catenacyber catenacyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed : needs

  • a warning
  • error when in "strict" mode

@jlucovsky
Copy link
Contributor Author

Continued in #13564

@jlucovsky jlucovsky closed this Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants