-
Notifications
You must be signed in to change notification settings - Fork 1.6k
detect/var: Restrict var usage to single buffer #13622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Issue: 1412 When in strict mode, issue an error and refuse to load the rule if variables produced from a different buffer are used with a separate buffer. When not in strict mode (default), issue a warning and load the rule. Only consider sig matches with compatible ids/lists.
Issue 1412 Add mention of byte_{extract,math,test,jump} variable usage and buffer scope and include how the command line option strict-rule-keywords affects validation.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #13622 +/- ##
==========================================
+ Coverage 83.69% 83.70% +0.01%
==========================================
Files 1011 1011
Lines 275071 275109 +38
==========================================
+ Hits 230210 230276 +66
+ Misses 44861 44833 -28
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Information: QA ran without warnings. Pipeline = 27037 |
I wonder what we want to do now that 8.0.0 is out and this was not merged in it 😢 |
Continued in #13716 |
Continuation of #13584
Issue: 1412
Extend the checks added for 7549 to include buffers.
Only consider sig matches with compatible ids/lists.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/1412
Describe changes:
buffers
init dataUpdates:
strict-rule-keywords
Provide values to any of the below to override the defaults.
link to the pull request in the respective
_BRANCH
variable.SV_REPO=
SV_BRANCH=OISF/suricata-verify#2576
SU_REPO=
SU_BRANCH=