detect/var: Restrict var usage to single buffer #13809
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: 1412 When in strict mode, issue an error and refuse to load the rule if variables produced from a different buffer are used with a separate buffer. When not in strict mode (default), issue a warning and load the rule. Only consider sig matches with compatible ids/lists.
Issue 1412
Add mention of byte_{extract,math,test,jump} variable usage
and buffer scope and include how the command line option
strict-rule-keywords affects validation.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #13809 +/- ##
==========================================
- Coverage 83.71% 83.71% -0.01%
==========================================
Files 1011 1011
Lines 275116 275153 +37
==========================================
+ Hits 230321 230342 +21
- Misses 44795 44811 +16
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Information: QA ran without warnings. Pipeline = 27344 |
catenacyber
reviewed
Sep 14, 2025
| void DetectByteExtractRegister(void); | ||
|
|
||
| SigMatch *DetectByteExtractRetrieveSMVar(const char *, int sm_list, const Signature *); | ||
| const SigMatch *DetectByteExtractRetrieveSMVar(const char *, int *found_list, const Signature *); |
There was a problem hiding this comment.
Just a reminder that there is some decision required here, see #13720 (comment)
|
Decision: Try to tackle https://redmine.openinfosecfoundation.org/issues/7801 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #13793
Issue: 1412
Extend the checks added for 7549 to include buffers.
Only consider sig matches with compatible ids/lists.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/1412
Describe changes:
buffersinit dataUpdates:
strict-rule-keywordsProvide values to any of the below to override the defaults.
link to the pull request in the respective
_BRANCHvariable.SV_REPO=
SV_BRANCH=OISF/suricata-verify#2576
SU_REPO=
SU_BRANCH=