Skip to content

Conversation

catenacyber
Copy link
Contributor

Link to ticket: https://redmine.openinfosecfoundation.org/issues/
None, just a script warning removal

Describe changes:

  • scripts: setup app layer does rustfmt mod.rs last

Otherwise rustfmt mod.rs complains that parser.rs does not exist yet

Otherwise rustfmt complains that parser.rs does not exist yet
@catenacyber catenacyber requested a review from a team as a code owner September 26, 2025 12:05
Copy link
Member

@jasonish jasonish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be backported to 8 as well.

@suricata-qa
Copy link

Information: QA skipped due to no C or rust code changed detected. Set to force a run.

Pipeline = code

@victorjulien victorjulien added this to the 9.0 milestone Sep 26, 2025
Copy link

codecov bot commented Sep 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.81%. Comparing base (9fb33bb) to head (176ee03).
⚠️ Report is 30 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13911      +/-   ##
==========================================
+ Coverage   78.66%   83.81%   +5.15%     
==========================================
  Files        1009     1009              
  Lines      275527   275551      +24     
==========================================
+ Hits       216730   230949   +14219     
+ Misses      58797    44602   -14195     
Flag Coverage Δ
fuzzcorpus 63.49% <ø> (?)
livemode 19.00% <ø> (+<0.01%) ⬆️
pcap 44.75% <ø> (+0.02%) ⬆️
suricata-verify 65.13% <ø> (-0.02%) ⬇️
unittests 59.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@victorjulien
Copy link
Member

Merged in #13926, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants