remove duplicate, conflicting declaration of hsubghz #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two symbol declarations with the same name:
One is in ./SOFTWARE/BB-STM32WLE-WAN/Core/Src/main.cpp and the other is in ./SOFTWARE/BB-STM32WLE-WAN/Core/Src/subghz.c
Given that subghz.h has an extern definition and "hsubghz" usage is primarily in main.cpp (and this is also where the variable is initialized via MX_SUBGHZ_Init() ), I presume subghz.c is the more sensible place to remove the duplicate.