[wip] use 1/4th of flash for character definitions #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works because for CH32v003 you can just set BR all the time and have BS determine the full state of a GPIO in the BSHR register. According to 7.3.1.4 of CH32V003RM: If both BR and BS bits are set, the BS bit takes effect. This moves some extra work to vga_prepare_line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works because for CH32v003 you can just set BR all the time and have BS determine the full state of a GPIO in the BSHR register.
According to 7.3.1.4 of CH32V003RM:
If both BR and BS bits are set, the BS bit takes effect.
As a trade-off this moves some extra work to vga_prepare_line. For me this slightly changes the glitch pattern.
Needs testing and also needs to be expanded to the
#ifdefareas of vga.c.