KEH-609 | Admin Access #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This will make the API Gateway redeploy itself if main.tf changes
- Previously, we were only getting the email from this but now we need the groups.
- Update /project/<proj> put method to check if user has admin group - If the user has admin group (cognito) or is listed within the user list, allow edit
- This also fixes the COGNITO_TOKEN_URL which is incorrect
mwirikia
reviewed
Oct 29, 2025
mwirikia
reviewed
Oct 29, 2025
- Removes multiple functions doing a similar thing - This does have a drawback where everything is collected even if it's not needed but that's fine
mwirikia
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
What
This fixes our current workaround of using shared credentials.
Testing
Have any new tests been added as part of this issue? If not, try to explain why test coverage is not needed here.
Please write a brief description of why test coverage is not necessary here.
Documentation
Has any new documentation been written as part of this issue? We should try to keep documentation up to date
as new code is added, rather than leaving it for the future.
Please write a brief description of why documentation is not necessary here.
Related issues
KEH-609 (Jira)
How to review
This is currently deployed to sdp-dev.
See the instructions in the UI PR.
ONS-Innovation/keh-tech-audit-tool#54