Skip to content

Add ability to remove sync and apm calls #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add ability to remove sync and apm calls #223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ebde0a4
Add ability to remove sync and apm calls
marcschier Aug 25, 2025
8b50724
Add ability to define obsoletion
marcschier Aug 25, 2025
4b9e0c9
Update formatting
marcschier Aug 25, 2025
e8ca6b5
Merge branch 'OPCFoundation:master' into nosync
marcschier Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Opc.Ua.ModelCompiler/StackGenerator/DataTypes/Templates/XmlSchema/Endpoint.wsdl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,4 +93,5 @@
</wsdl:service>

</wsdl:definitions>

<!--***END***-->
1 change: 1 addition & 0 deletions Opc.Ua.ModelCompiler/StackGenerator/DataTypes/Templates/XmlSchema/Services.wsdl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,4 +63,5 @@
</wsdl:portType>

</wsdl:definitions>

<!--***END***-->
14 changes: 13 additions & 1 deletion Opc.Ua.ModelCompiler/StackGenerator/DotNet/Templates/Channels/XmlMethodAsync.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,13 @@ public _NAME_ResponseMessage End_NAME_(IAsyncResult result)
}
}
#else // NET_STANDARD
#if (!NET_STANDARD_NO_SYNC && !NET_STANDARD_NO_APM)
/// <summary>
/// The client side implementation of the _NAME_ service contract.
/// </summary>
#if (NET_STANDARD_OBSOLETE_SYNC && NET_STANDARD_ASYNC)
[Obsolete("Sync methods are deprecated in this version. Use _NAME_Async instead.")]
#endif
public _NAME_ResponseMessage _NAME_(_NAME_Message request)
{
IAsyncResult result = null;
Expand All @@ -72,10 +76,14 @@ public _NAME_ResponseMessage _NAME_(_NAME_Message request)

return this.Channel.End_NAME_(result);
}

#endif
#if (!NET_STANDARD_NO_APM)
/// <summary>
/// The client side implementation of the Begin_NAME_ service contract.
/// </summary>
#if (NET_STANDARD_OBSOLETE_APM && NET_STANDARD_ASYNC)
[Obsolete("Begin/End methods are deprecated in this version. Use _NAME_Async instead.")]
#endif
public IAsyncResult Begin_NAME_(_NAME_Message request, AsyncCallback callback, object asyncState)
{
UaChannelAsyncResult asyncResult = new UaChannelAsyncResult(Channel, callback, asyncState);
Expand All @@ -91,12 +99,16 @@ public IAsyncResult Begin_NAME_(_NAME_Message request, AsyncCallback callback, o
/// <summary>
/// The client side implementation of the End_NAME_ service contract.
/// </summary>
#if (NET_STANDARD_OBSOLETE_APM && NET_STANDARD_ASYNC)
[Obsolete("Begin/End methods are deprecated in this version. Use _NAME_Async instead.")]
#endif
public _NAME_ResponseMessage End_NAME_(IAsyncResult result)
{
UaChannelAsyncResult asyncResult = UaChannelAsyncResult.WaitForComplete(result);
return asyncResult.Channel.End_NAME_(asyncResult.InnerResult);
}
#endif
#endif

#if (NET_STANDARD_ASYNC)
/// <summary>
Expand Down
13 changes: 13 additions & 0 deletions Opc.Ua.ModelCompiler/StackGenerator/DotNet/Templates/ClientApi/Interface.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,20 +3,33 @@ class Placeholder
// ***START***
#region _NAME_ Methods
#if (!OPCUA_EXCLUDE__NAME_)
#if (!NET_STANDARD_NO_SYNC && !NET_STANDARD_NO_APM)
/// <summary>
/// Invokes the _NAME_ service.
/// </summary>
#if (NET_STANDARD_OBSOLETE_SYNC && NET_STANDARD_ASYNC)
[Obsolete("Sync methods are deprecated in this version. Use _NAME_Async instead.")]
#endif
void SyncCall();
#endif

#if (!NET_STANDARD_NO_APM)
/// <summary>
/// Begins an asynchronous invocation of the _NAME_ service.
/// </summary>
#if (NET_STANDARD_OBSOLETE_APM && NET_STANDARD_ASYNC)
[Obsolete("Begin/End methods are deprecated in this version. Use _NAME_Async instead.")]
#endif
void BeginAsyncCall();

/// <summary>
/// Finishes an asynchronous invocation of the _NAME_ service.
/// </summary>
#if (NET_STANDARD_OBSOLETE_APM && NET_STANDARD_ASYNC)
[Obsolete("Begin/End methods are deprecated in this version. Use _NAME_Async instead.")]
#endif
void EndAsyncCall();
#endif

#if (NET_STANDARD_ASYNC)
/// <summary>
Expand Down
13 changes: 13 additions & 0 deletions Opc.Ua.ModelCompiler/StackGenerator/DotNet/Templates/ClientApi/Method.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,9 +116,13 @@ void EndAsyncCall()
return response.ResponseHeader;
}
#else // NET_STANDARD
#if (!NET_STANDARD_NO_SYNC && !NET_STANDARD_NO_APM)
/// <summary>
/// Invokes the _NAME_ service.
/// </summary>
#if (NET_STANDARD_OBSOLETE_SYNC && NET_STANDARD_ASYNC)
[Obsolete("Sync methods are deprecated in this version. Use _NAME_Async instead.")]
#endif
void SyncCall()
{
_NAME_Request request = new _NAME_Request();
Expand Down Expand Up @@ -149,10 +153,15 @@ void SyncCall()

return response.ResponseHeader;
}
#endif

#if (!NET_STANDARD_NO_APM)
/// <summary>
/// Begins an asynchronous invocation of the _NAME_ service.
/// </summary>
#if (NET_STANDARD_OBSOLETE_APM && NET_STANDARD_ASYNC)
[Obsolete("Begin/End methods are deprecated in this version. Use _NAME_Async instead.")]
#endif
void BeginAsyncCall()
{
_NAME_Request request = new _NAME_Request();
Expand All @@ -167,6 +176,9 @@ void BeginAsyncCall()
/// <summary>
/// Finishes an asynchronous invocation of the _NAME_ service.
/// </summary>
#if (NET_STANDARD_OBSOLETE_APM && NET_STANDARD_ASYNC)
[Obsolete("Begin/End methods are deprecated in this version. Use _NAME_Async instead.")]
#endif
void EndAsyncCall()
{
_NAME_Response response = null;
Expand All @@ -193,6 +205,7 @@ void EndAsyncCall()
return response.ResponseHeader;
}
#endif
#endif

#if (NET_STANDARD_ASYNC)
/// <summary>
Expand Down
10 changes: 10 additions & 0 deletions Opc.Ua.ModelCompiler/StackGenerator/DotNet/Templates/Interfaces/OperationAsync.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,24 +5,34 @@ class Placeholder
/// <summary>
/// The operation contract for the _NAME_ service.
/// </summary>
#if (!NET_STANDARD_NO_SYNC && !NET_STANDARD_NO_APM)
#if (!NET_STANDARD)
[OperationContract(Action = Namespaces._ServicesNamespace_ + "/_NAME_", ReplyAction = Namespaces._ServicesNamespace_ + "/_NAME_Response")]
[FaultContract(typeof(ServiceFault), Action = Namespaces._ServicesNamespace_ + "/_NAME_Fault", Name="ServiceFault", Namespace=Namespaces._TypesNamespace_)]
#endif
#if (NET_STANDARD_OBSOLETE_SYNC && NET_STANDARD_ASYNC)
[Obsolete("Sync methods are deprecated in this version. Use _NAME_Async instead.")]
#endif
_NAME_ResponseMessage _NAME_(_NAME_Message request);
#endif

/// <summary>
/// The operation contract for the _NAME_ service.
/// </summary>
#if (!NET_STANDARD_NO_APM)
#if (!NET_STANDARD)
[OperationContractAttribute(AsyncPattern=true, Action=Namespaces._ServicesNamespace_ + "/_NAME_", ReplyAction = Namespaces._ServicesNamespace_ + "/_NAME_Response")]
#endif
#if (NET_STANDARD_OBSOLETE_APM && NET_STANDARD_ASYNC)
[Obsolete("Begin/e methods are deprecated in this version. Use _NAME_Async instead.")]
#endif
IAsyncResult Begin_NAME_(_NAME_Message request, AsyncCallback callback, object asyncState);

/// <summary>
/// The method used to retrieve the results of a _NAME_ service request.
/// </summary>
_NAME_ResponseMessage End_NAME_(IAsyncResult result);
#endif

#if (NET_STANDARD_ASYNC)
/// <summary>
Expand Down
Loading