Skip to content

Commit fb7adbc

Browse files
committed
Fix initExpanded being incorrectly handled
1 parent db4d709 commit fb7adbc

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

frontend/src/components/ReviewBox.jsx

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ const Review = ({ review, endpoint, onUpdate }) => {
119119

120120
const ReviewBox = ({ children, title, endpoint, initExpanded }) => {
121121
const [reviewsList, setReviewsList] = useState(null);
122-
const [isExpanded, setIsExpanded] = useState(initExpanded);
122+
const [isExpanded, setIsExpanded] = useState(false);
123123
const cache = useRef({}); // Cache for reviews data
124124

125125
const fetchReviews = async () => {
@@ -138,6 +138,11 @@ const ReviewBox = ({ children, title, endpoint, initExpanded }) => {
138138
setIsExpanded(!isExpanded);
139139
};
140140

141+
/* init expanded when endpoint changes */
142+
useEffect(() => {
143+
setIsExpanded(initExpanded);
144+
}, [endpoint]);
145+
141146
useEffect(() => {
142147
if (isExpanded) {
143148
if (cache.current[endpoint]) {
@@ -148,7 +153,7 @@ const ReviewBox = ({ children, title, endpoint, initExpanded }) => {
148153
} else {
149154
setReviewsList(null);
150155
}
151-
}, [endpoint, isExpanded]);
156+
}, [isExpanded]);
152157

153158
return (
154159
<Card

0 commit comments

Comments
 (0)