Skip to content

Commit 2f2cc7c

Browse files
committed
update assertions in unit test
Signed-off-by: Natasja Nortier <natasja.nortier@alliander.com>
1 parent ea2e21d commit 2f2cc7c

File tree

1 file changed

+10
-11
lines changed
  • osgp/protocol-adapter-dlms/osgp-protocol-adapter-dlms/src/test/java/org/opensmartgridplatform/adapter/protocol/dlms/application/services

1 file changed

+10
-11
lines changed

osgp/protocol-adapter-dlms/osgp-protocol-adapter-dlms/src/test/java/org/opensmartgridplatform/adapter/protocol/dlms/application/services/SecretManagementServiceTest.java

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,13 @@
55
package org.opensmartgridplatform.adapter.protocol.dlms.application.services;
66

77
import static org.assertj.core.api.Assertions.assertThat;
8-
import static org.junit.jupiter.api.Assertions.assertThrows;
8+
import static org.assertj.core.api.Assertions.assertThatThrownBy;
99
import static org.mockito.ArgumentMatchers.any;
1010
import static org.mockito.ArgumentMatchers.same;
1111
import static org.mockito.Mockito.times;
1212
import static org.mockito.Mockito.verify;
1313
import static org.mockito.Mockito.when;
1414

15-
import java.util.Arrays;
1615
import java.util.EnumMap;
1716
import java.util.List;
1817
import java.util.Map;
@@ -74,7 +73,7 @@ public void init() {
7473

7574
@Test
7675
void testGetKeys() {
77-
final List<SecurityKeyType> keyTypes = Arrays.asList(KEY_TYPE);
76+
final List<SecurityKeyType> keyTypes = List.of(KEY_TYPE);
7877
final GetSecretsResponse response = new GetSecretsResponse();
7978
response.setResult(OsgpResultType.OK);
8079
response.setTypedSecrets(new TypedSecrets());
@@ -117,17 +116,17 @@ void testStoreNewKeysThrowsException() {
117116
when(this.secretManagementClient.storeSecretsRequest(same(messageMetadata), any()))
118117
.thenThrow(new RuntimeException("Simulated exception"));
119118

120-
assertThrows(
121-
StoreNewKeyException.class,
122-
() -> {
123-
this.secretManagementTestService.storeNewKeys(
124-
messageMetadata, DEVICE_IDENTIFICATION, keys);
125-
});
119+
assertThatThrownBy(
120+
() -> {
121+
this.secretManagementTestService.storeNewKeys(
122+
messageMetadata, DEVICE_IDENTIFICATION, keys);
123+
})
124+
.isInstanceOf(StoreNewKeyException.class);
126125
}
127126

128127
@Test
129128
void testActivateKeys() {
130-
final List<SecurityKeyType> keyTypes = Arrays.asList(KEY_TYPE);
129+
final List<SecurityKeyType> keyTypes = List.of(KEY_TYPE);
131130
final ArgumentCaptor<ActivateSecretsRequest> activateSecretsCaptor =
132131
ArgumentCaptor.forClass(ActivateSecretsRequest.class);
133132
// EXECUTE
@@ -144,7 +143,7 @@ void testActivateKeys() {
144143

145144
@Test
146145
void testGenerateAndStoreKeys() {
147-
final List<SecurityKeyType> keyTypes = Arrays.asList(KEY_TYPE);
146+
final List<SecurityKeyType> keyTypes = List.of(KEY_TYPE);
148147
final GenerateAndStoreSecretsResponse response = new GenerateAndStoreSecretsResponse();
149148
response.setResult(OsgpResultType.OK);
150149
response.setTypedSecrets(new TypedSecrets());

0 commit comments

Comments
 (0)