Skip to content

Commit bff969c

Browse files
authored
Merge pull request #1364 from OSGP/feature/OPS-sonar
OPS: Suppress supposed Sonar issue
2 parents a1f3a82 + f55b195 commit bff969c

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

osgp/protocol-adapter-dlms/osgp-jasper-interface/src/main/java/org/opensmartgridplatform/adapter/protocol/jasper/infra/ws/JasperWirelessSmsSoapClient.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,9 @@ GetSMSDetailsResponse getSMSDetails(final Long smsMessageId, final String iccId)
107107
getSMSDetailsRequest, new SoapActionCallback(SERVICE_GET_SMSDETAILS));
108108
}
109109

110+
// Sonar marks 'setSecurementPasswordType(WSConstants.PW_TEXT)' as exposing a password.
111+
// This is wrong, it just sets the password *type*
112+
@SuppressWarnings("java:S6437")
110113
private void setUsernameToken(
111114
final Wss4jSecurityInterceptor interceptor, final String user, final String pass) {
112115
interceptor.setSecurementUsername(user);

osgp/protocol-adapter-dlms/osgp-jasper-interface/src/main/java/org/opensmartgridplatform/adapter/protocol/jasper/infra/ws/JasperWirelessTerminalSoapClient.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,9 @@ private void validateResponse(final GetSessionInfoResponse response) throws Osgp
9191
sessionInfoType.getDateSessionEnded().toGregorianCalendar().getTime());
9292
}
9393

94+
// Sonar marks 'setSecurementPasswordType(WSConstants.PW_TEXT)' as exposing a password.
95+
// This is wrong, it just sets the password *type*
96+
@SuppressWarnings("java:S6437")
9497
private static void setUsernameToken(
9598
final Wss4jSecurityInterceptor interceptor, final String user, final String pass) {
9699
interceptor.setSecurementUsername(user);

0 commit comments

Comments
 (0)