Skip to content

Conversation

twerthi
Copy link
Contributor

@twerthi twerthi commented Sep 8, 2025


Background

The underlying cmdlet updated to include a connection name. This PR updates the template to use the new connection name argument as well as updates the finally of the try/catch. Previously, it would attempt to close the connection to the database, however, if no connection had been made, this would hide the original failure behind the failure of closing the connection.

Results

Finally now tests to see if the connection is open before attempting to close it. This will no longer cause the original error to be obscured by trying to close a closed connection.

Before

Original error obscured by the finally trying to close a closed connection.

After

Finally now tests to see if it the connection is open before trying to close it.

Pre-requisites

  • Id should be a GUID that is not 00000000-0000-0000-0000-000000000000
    • NOTE If you are modifying an existing step template, please make sure that you do not modify the Id property (updating the Id will break the Library sync functionality in Octopus).
  • Version should be incremented, otherwise the integration with Octopus won't update the step template correctly
  • Parameter names should not start with $
  • Step template parameter names (the ones declared in the JSON, not the script body) should be prefixed with a namespace so that they are less likely to clash with other user-defined variables in Octopus (see this issue). For example, use an abbreviated name of the step template or the category of the step template).
  • LastModifiedBy field must be present, and (optionally) updated with the correct author
  • The best practices documented here have been applied
  • If a new Category has been created:
    • An image with the name {categoryname}.png must be present under the step-templates/logos folder
    • The switch in the humanize function in gulpfile.babel.js must have a case statement corresponding to it

Copy link

github-actions bot commented Sep 8, 2025

Start Hyponome locally

docker pull ghcr.io/hnrkndrssn/hyponome:main
docker run --rm -p 8000:8080 -it ghcr.io/hnrkndrssn/hyponome:main

Review in Hyponome

@mik-ky mik-ky merged commit 1cca9b3 into master Sep 8, 2025
2 checks passed
@mik-ky mik-ky deleted the update-postgres-execute-sql branch September 8, 2025 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants