Skip to content

Change HttpRouteExtractor access modifier to public to match interface #871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Change HttpRouteExtractor access modifier to public to match interface #871

wants to merge 1 commit into from

Conversation

500error
Copy link

@500error 500error commented Sep 9, 2024

OctopusAsyncClient takes an IHttpRouteExtractor in its constructor, but the default implementation HttpRouteExtractor is not public.

Changing this class to public makes any inheritance of OctopusAsyncClient (and HttpRouteExtractor itself) much simpler.

@CLAassistant
Copy link

CLAassistant commented Sep 9, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@nathanwoctopusdeploy nathanwoctopusdeploy mentioned this pull request Sep 17, 2024
Merged
@500error 500error closed this Sep 17, 2024
@500error 500error deleted the tj/public-httprouteextractor branch September 17, 2024 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@500error @CLAassistant