From 45e310a6e0123a119ef2ff32ff5af441a0a0dffa Mon Sep 17 00:00:00 2001
From: Chris Kim <chris.kim@octopus.com>
Date: Thu, 10 Oct 2024 15:07:38 +1300
Subject: [PATCH] Use referencecollections over arrays

---
 ...ublicSurfaceAreaShouldNotRegress..NETCore.approved.txt | 8 ++++----
 ...SurfaceAreaShouldNotRegress..NETFramework.approved.txt | 8 ++++----
 .../ModifyCommonVariablesByTenantIdCommand.cs             | 6 +++---
 .../ModifyProjectVariablesByTenantIdCommand.cs            | 4 ++--
 4 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/source/Octopus.Client.Tests/PublicSurfaceAreaFixture.ThePublicSurfaceAreaShouldNotRegress..NETCore.approved.txt b/source/Octopus.Client.Tests/PublicSurfaceAreaFixture.ThePublicSurfaceAreaShouldNotRegress..NETCore.approved.txt
index afe6dda95..5cc3f7c50 100644
--- a/source/Octopus.Client.Tests/PublicSurfaceAreaFixture.ThePublicSurfaceAreaShouldNotRegress..NETCore.approved.txt
+++ b/source/Octopus.Client.Tests/PublicSurfaceAreaFixture.ThePublicSurfaceAreaShouldNotRegress..NETCore.approved.txt
@@ -7299,8 +7299,8 @@ Octopus.Client.Model.TenantVariables
 {
   class CommonVariableScope
   {
-    .ctor(String[])
-    String[] EnvironmentIds { get; set; }
+    .ctor(Octopus.Client.Model.ReferenceCollection)
+    Octopus.Client.Model.ReferenceCollection EnvironmentIds { get; set; }
   }
   class ModifyCommonVariablesByTenantIdCommand
   {
@@ -7330,8 +7330,8 @@ Octopus.Client.Model.TenantVariables
   }
   class ProjectVariableScope
   {
-    .ctor(String[])
-    String[] EnvironmentIds { get; set; }
+    .ctor(Octopus.Client.Model.ReferenceCollection)
+    Octopus.Client.Model.ReferenceCollection EnvironmentIds { get; set; }
   }
   class TenantCommonVariable
   {
diff --git a/source/Octopus.Client.Tests/PublicSurfaceAreaFixture.ThePublicSurfaceAreaShouldNotRegress..NETFramework.approved.txt b/source/Octopus.Client.Tests/PublicSurfaceAreaFixture.ThePublicSurfaceAreaShouldNotRegress..NETFramework.approved.txt
index c0e7cc9e7..94f052ca0 100644
--- a/source/Octopus.Client.Tests/PublicSurfaceAreaFixture.ThePublicSurfaceAreaShouldNotRegress..NETFramework.approved.txt
+++ b/source/Octopus.Client.Tests/PublicSurfaceAreaFixture.ThePublicSurfaceAreaShouldNotRegress..NETFramework.approved.txt
@@ -7323,8 +7323,8 @@ Octopus.Client.Model.TenantVariables
 {
   class CommonVariableScope
   {
-    .ctor(String[])
-    String[] EnvironmentIds { get; set; }
+    .ctor(Octopus.Client.Model.ReferenceCollection)
+    Octopus.Client.Model.ReferenceCollection EnvironmentIds { get; set; }
   }
   class ModifyCommonVariablesByTenantIdCommand
   {
@@ -7354,8 +7354,8 @@ Octopus.Client.Model.TenantVariables
   }
   class ProjectVariableScope
   {
-    .ctor(String[])
-    String[] EnvironmentIds { get; set; }
+    .ctor(Octopus.Client.Model.ReferenceCollection)
+    Octopus.Client.Model.ReferenceCollection EnvironmentIds { get; set; }
   }
   class TenantCommonVariable
   {
diff --git a/source/Octopus.Server.Client/Model/TenantVariables/ModifyCommonVariablesByTenantIdCommand.cs b/source/Octopus.Server.Client/Model/TenantVariables/ModifyCommonVariablesByTenantIdCommand.cs
index c6044ed25..981fb960d 100644
--- a/source/Octopus.Server.Client/Model/TenantVariables/ModifyCommonVariablesByTenantIdCommand.cs
+++ b/source/Octopus.Server.Client/Model/TenantVariables/ModifyCommonVariablesByTenantIdCommand.cs
@@ -23,9 +23,9 @@ public class TenantCommonVariable(string libraryVariableSetId, string templateId
     public CommonVariableScope Scope { get; set; } = scope;
 }
 
-public class CommonVariableScope(string[] environmentIds)
+public class CommonVariableScope(ReferenceCollection environmentIds)
 {
-    public string[] EnvironmentIds { get; set; } = environmentIds;
+    public ReferenceCollection EnvironmentIds { get; set; } = environmentIds;
 }
 
 public class ModifyCommonVariablesByTenantIdResponse(string tenantId, TenantCommonVariable[] commonVariables)
@@ -33,4 +33,4 @@ public class ModifyCommonVariablesByTenantIdResponse(string tenantId, TenantComm
     public string TenantId { get; set; } = tenantId;
         
     public TenantCommonVariable[] CommonVariables { get; set; } = commonVariables;
-}
\ No newline at end of file
+}
diff --git a/source/Octopus.Server.Client/Model/TenantVariables/ModifyProjectVariablesByTenantIdCommand.cs b/source/Octopus.Server.Client/Model/TenantVariables/ModifyProjectVariablesByTenantIdCommand.cs
index 1e48eba9b..9b8031e8f 100644
--- a/source/Octopus.Server.Client/Model/TenantVariables/ModifyProjectVariablesByTenantIdCommand.cs
+++ b/source/Octopus.Server.Client/Model/TenantVariables/ModifyProjectVariablesByTenantIdCommand.cs
@@ -26,9 +26,9 @@ public class TenantProjectVariable(
     public ProjectVariableScope Scope { get; set; } = scope;
 }
 
-public class ProjectVariableScope(string[] environmentIds)
+public class ProjectVariableScope(ReferenceCollection environmentIds)
 {
-    public string[] EnvironmentIds { get; set; } = environmentIds;
+    public ReferenceCollection EnvironmentIds { get; set; } = environmentIds;
 }
 
 public class ModifyProjectVariablesByTenantIdResponse(string tenantId, TenantProjectVariable[] projectVariables)