Skip to content

Use referencecollections over arrays for common variable method #875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Use referencecollections over arrays for common variable method #875

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45e310a
Use referencecollections over arrays
mik-ky Oct 10, 2024
c7b89ab
Merge pull request #879 from OctopusDeploy/fnm/use-ref-collections-ov…
mik-ky Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...Tests/PublicSurfaceAreaFixture.ThePublicSurfaceAreaShouldNotRegress..NETCore.approved.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7299,8 +7299,8 @@ Octopus.Client.Model.TenantVariables
{
class CommonVariableScope
{
.ctor(String[])
String[] EnvironmentIds { get; set; }
.ctor(Octopus.Client.Model.ReferenceCollection)
Octopus.Client.Model.ReferenceCollection EnvironmentIds { get; set; }
}
class GetCommonVariablesByTenantIdRequest
{
Expand Down Expand Up @@ -7354,8 +7354,8 @@ Octopus.Client.Model.TenantVariables
}
class ProjectVariableScope
{
.ctor(String[])
String[] EnvironmentIds { get; set; }
.ctor(Octopus.Client.Model.ReferenceCollection)
Octopus.Client.Model.ReferenceCollection EnvironmentIds { get; set; }
}
class TenantCommonVariable
{
Expand Down
8 changes: 4 additions & 4 deletions .../PublicSurfaceAreaFixture.ThePublicSurfaceAreaShouldNotRegress..NETFramework.approved.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7323,8 +7323,8 @@ Octopus.Client.Model.TenantVariables
{
class CommonVariableScope
{
.ctor(String[])
String[] EnvironmentIds { get; set; }
.ctor(Octopus.Client.Model.ReferenceCollection)
Octopus.Client.Model.ReferenceCollection EnvironmentIds { get; set; }
}
class GetCommonVariablesByTenantIdRequest
{
Expand Down Expand Up @@ -7378,8 +7378,8 @@ Octopus.Client.Model.TenantVariables
}
class ProjectVariableScope
{
.ctor(String[])
String[] EnvironmentIds { get; set; }
.ctor(Octopus.Client.Model.ReferenceCollection)
Octopus.Client.Model.ReferenceCollection EnvironmentIds { get; set; }
}
class TenantCommonVariable
{
Expand Down
6 changes: 3 additions & 3 deletions source/Octopus.Server.Client/Model/TenantVariables/ModifyCommonVariablesByTenantIdCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,14 @@ public class TenantCommonVariable(string libraryVariableSetId, string templateId
public CommonVariableScope Scope { get; set; } = scope;
}

public class CommonVariableScope(string[] environmentIds)
public class CommonVariableScope(ReferenceCollection environmentIds)
{
public string[] EnvironmentIds { get; set; } = environmentIds;
public ReferenceCollection EnvironmentIds { get; set; } = environmentIds;
}

public class ModifyCommonVariablesByTenantIdResponse(string tenantId, TenantCommonVariable[] commonVariables)
{
public string TenantId { get; set; } = tenantId;

public TenantCommonVariable[] CommonVariables { get; set; } = commonVariables;
}
}
4 changes: 2 additions & 2 deletions ...ce/Octopus.Server.Client/Model/TenantVariables/ModifyProjectVariablesByTenantIdCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@ public class TenantProjectVariable(
public ProjectVariableScope Scope { get; set; } = scope;
}

public class ProjectVariableScope(string[] environmentIds)
public class ProjectVariableScope(ReferenceCollection environmentIds)
{
public string[] EnvironmentIds { get; set; } = environmentIds;
public ReferenceCollection EnvironmentIds { get; set; } = environmentIds;
}

public class ModifyProjectVariablesByTenantIdResponse(string tenantId, TenantProjectVariable[] projectVariables)
Expand Down
Loading