Skip to content

Conversation

enf0rc3
Copy link
Contributor

@enf0rc3 enf0rc3 commented Jun 10, 2025

Background

The current implementation of the RunbookRetentionPeriod model in Octopus.Client does not fully align with the server's data contract. Specifically, it lacks the Unit property, which the server supports.

Result

This PR introduces the Unit property as an enum to the RunbookRetentionPeriod model in Octopus.Client to match the server's contract.

Additional Details

Current RunbookRetentionPeriod in Octopus.Client:

namespace Octopus.Client.Model
{
    public class RunbookRetentionPeriod
    {
        public int QuantityToKeep { get; set; }

        public bool ShouldKeepForever { get; set; }
    }
}

Current RunbookRetentionPeriod on Server (as per Swagger documentation ):

RunbookRetentionPeriod{
  QuantityToKeep	integer($int32)
  ShouldKeepForever	boolean
  readOnly: true
  Unit	string
}

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@desruc desruc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for aligning these.

@enf0rc3 enf0rc3 force-pushed the bft/will/runbook-retentionunit branch from e130a77 to 1455e55 Compare June 11, 2025 23:35
@enf0rc3 enf0rc3 merged commit 40560bf into master Jun 12, 2025
6 of 7 checks passed
@enf0rc3 enf0rc3 deleted the bft/will/runbook-retentionunit branch June 12, 2025 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants