Skip to content

FailTargetDiscovery on deployment settings and runbook run #939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 16, 2025
Merged

FailTargetDiscovery on deployment settings and runbook run #939

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4c4cb22
new stuff
susanpann Jul 1, 2025
5680947
update deployment resource
susanpann Jul 15, 2025
4516eb7
runbookresource
susanpann Jul 15, 2025
e5c00da
surface area fixture
susanpann Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...Tests/PublicSurfaceAreaFixture.ThePublicSurfaceAreaShouldNotRegress..NETCore.approved.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2890,6 +2890,7 @@ Octopus.Client.Model
Octopus.Client.Model.GuidedFailureMode DefaultGuidedFailureMode { get; set; }
Boolean DefaultToSkipIfAlreadyInstalled { get; set; }
String DeploymentChangesTemplate { get; set; }
Boolean FailTargetDiscovery { get; set; }
Boolean ForcePackageDownload { get; set; }
String ProjectId { get; set; }
String ReleaseNotesTemplate { get; set; }
Expand Down Expand Up @@ -5171,6 +5172,7 @@ Octopus.Client.Model
Octopus.Client.Model.ReferenceCollection DeployedToMachineIds { get; set; }
String EnvironmentId { get; set; }
Octopus.Client.Model.ReferenceCollection ExcludedMachineIds { get; set; }
Boolean FailTargetDiscovery { get; set; }
Boolean FailureEncountered { get; set; }
Boolean ForcePackageDownload { get; set; }
Dictionary<String, String> FormValues { get; set; }
Expand Down
2 changes: 2 additions & 0 deletions .../PublicSurfaceAreaFixture.ThePublicSurfaceAreaShouldNotRegress..NETFramework.approved.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2906,6 +2906,7 @@ Octopus.Client.Model
Octopus.Client.Model.GuidedFailureMode DefaultGuidedFailureMode { get; set; }
Boolean DefaultToSkipIfAlreadyInstalled { get; set; }
String DeploymentChangesTemplate { get; set; }
Boolean FailTargetDiscovery { get; set; }
Boolean ForcePackageDownload { get; set; }
String ProjectId { get; set; }
String ReleaseNotesTemplate { get; set; }
Expand Down Expand Up @@ -5189,6 +5190,7 @@ Octopus.Client.Model
Octopus.Client.Model.ReferenceCollection DeployedToMachineIds { get; set; }
String EnvironmentId { get; set; }
Octopus.Client.Model.ReferenceCollection ExcludedMachineIds { get; set; }
Boolean FailTargetDiscovery { get; set; }
Boolean FailureEncountered { get; set; }
Boolean ForcePackageDownload { get; set; }
Dictionary<String, String> FormValues { get; set; }
Expand Down
3 changes: 3 additions & 0 deletions source/Octopus.Server.Client/Model/DeploymentSettingsResource.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,5 +31,8 @@ public class DeploymentSettingsResource : Resource, IHaveSpaceResource

[Writeable]
public bool ForcePackageDownload { get; set; }

[Writeable]
public bool FailTargetDiscovery { get; set; }
}
}
8 changes: 7 additions & 1 deletion source/Octopus.Server.Client/Model/RunbookRunResource.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,13 @@ public RunbookRunResource()
/// </summary>
[WriteableOnCreate]
public string DebugMode { get; set; }


/// <summary>
/// If set to true, target discovery steps that find no matching targets will fail. If false, steps with no matching targets will be skipped.
/// </summary>
[WriteableOnCreate]
public bool FailTargetDiscovery { get; set; }

/// <summary>
/// One of the values from <see cref="RunbookRunPriority"/>
/// </summary>
Expand Down