Skip to content

Conversation

rhysparry
Copy link
Contributor

@rhysparry rhysparry commented Aug 6, 2025

Background

For ScriptServiceV1, a call to GetStatus may not return the full log
information if the logs have not yet been flushed. This change updates
the client to perform a second GetStatus check to attempt to fetch any
additional logs.

Results

How to review this PR

  • Quality
  • Test Coverage

Pre-requisites

  • I have read How we use GitHub Issues for help deciding when and where it's appropriate to make an issue.
  • I have considered informing or consulting the right people, according to the ownership map.
  • I have considered appropriate testing for my change.

For ScriptServiceV1, a call to `GetStatus` may not return the full log
information if the logs have not yet been flushed. This change updates
the client to perform a second GetStatus check to attempt to fetch any
additional logs.
@rhysparry rhysparry requested a review from a team as a code owner August 6, 2025 03:47
@rhysparry rhysparry merged commit 4f67fe8 into main Aug 6, 2025
52 checks passed
@rhysparry rhysparry deleted the rhys/double-check-ssv1-complete-status branch August 6, 2025 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calling GetStatus in ScriptService (V1) may not return all process output although the process shows as complete
2 participants