Update referenced version of Octopus.Client to 17.0.2288 to correct code signatures. Update global.json to reference 8.0.413 to pick up security fixes for net8 self-contained tentacle #1119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ode signatures. Update global.json to reference 8.0.413 to pick up security fixes for net8 self-contained tentacle
rhysparry
approved these changes
Aug 15, 2025
| <ItemGroup> | ||
| <PackageReference Include="BouncyCastle.Cryptography" Version="2.5.1" /> | ||
| <PackageReference Include="Octopus.Client" Version="15.2.2240" /> | ||
| <PackageReference Include="Octopus.Client" Version="17.0.2288" /> |
There was a problem hiding this comment.
Changes seem reasonable to me. It doesn't look like we're impacted by breaking changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
A customer used a scanning tool to inspect our current release of Tentacle (8.0.3103 at time of writing).
The tool showed
Octopus.Client.dllbundled with Tentacle had an invalid code signature8.0.7of the .NET runtimeResults
The Octopus.Client code signature was corrected in release 17.0.2288
This PR
global.jsonfile which will cause Tentacle to build with the current8.0.19version of the .NET runtime.[SC-118759]
Fixes #1121
Fixes #1122
How to review this PR
Quality ✔️
The PR validation build passed all tests. I manually verified that the bundled .NET runtime is now 8.0.19
Pre-requisites