Skip to content

Conversation

LukeButters
Copy link
Contributor

@LukeButters LukeButters commented Aug 29, 2025

Background

This fixes a bug in the watcher and also makes it possible to have the in memory log actually log to in memory only.

The changes wont affect tentacle itself.

How to review this PR

Quality ✔️

Pre-requisites

  • I have read How we use GitHub Issues for help deciding when and where it's appropriate to make an issue.
  • I have considered informing or consulting the right people, according to the ownership map.
  • I have considered appropriate testing for my change.

@LukeButters LukeButters requested a review from a team as a code owner August 29, 2025 06:08
Copy link
Contributor

@rhysparry rhysparry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM

@LukeButters LukeButters merged commit 6609577 into main Sep 2, 2025
51 checks passed
@LukeButters LukeButters deleted the luke/upgrade-to-halibut-8.1.1503 branch September 2, 2025 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants