Add .NET 8 Targets #991
Add .NET 8 Targets #991
Conversation
rhysparry
force-pushed
the
sast/sc-85314/dotnet-8-targeting
branch
from
bf34e45 to
869b05f
Compare
rhysparry
force-pushed
the
sast/sc-85314/dotnet-8-targeting
branch
from
869b05f to
37df7a7
Compare
source/Octopus.Tentacle.Tests.Integration/Support/RuntimeDetection.cs
Outdated
Show resolved
Hide resolved
This reverts commit 0f4cd3d.
...s.Tentacle.Kubernetes.Tests.Integration/Octopus.Tentacle.Kubernetes.Tests.Integration.csproj
Outdated
Show resolved
Hide resolved
...e/Octopus.Tentacle.Tests.Integration.Common/Octopus.Tentacle.Tests.Integration.Common.csproj
Outdated
Show resolved
Hide resolved
source/Octopus.Tentacle.Tests.Integration/Support/IntegrationTestTimeout.cs
Show resolved
Hide resolved
| // Tentacle 8.2 is/was built on .NET8, previous versions were built on .NET6 | ||
| string runtimeForVersion = version.Major >= 8 && version.Minor >= 2 | ||
| ? RuntimeDetection.DotNet8 | ||
| : RuntimeDetection.DotNet6; |
There was a problem hiding this comment.
With everything on .NET 8 we might not need this any more.
There was a problem hiding this comment.
This one is sus. 2 attempts to remove the NET6 reference resulted in a massive test failure.
-42fd80a#diff-902a65266fdc53157ba08edabaff0a144b82f643004614fd6aabd3cb72f247e7
CC: @acodrington
There was a problem hiding this comment.
At this point, I'll revert the change first to get a green build.
There was a problem hiding this comment.
This is likely to be the reason, https://docs.google.com/document/d/1bVnkDoctYpf-GdkoAPzGTc5Oyj_O2NlwqRl43Gv3MwM/edit#bookmark=id.976uxf7b549q
- I didn't do any further investigation though.
There was a problem hiding this comment.
Or don't and reference the Octopus Server PR where the same change was made
There was a problem hiding this comment.
Reverted. (Will observe any build issue)
| <PackageReference Include="KubernetesClient" Version="13.0.26" /> | ||
| </ItemGroup> | ||
| <ItemGroup Condition="'$(TargetFramework)' == 'net8.0' Or '$(TargetFramework)' == 'net8.0-windows'"> | ||
| <PackageReference Include="KubernetesClient" Version="13.0.26" /> |
There was a problem hiding this comment.
Check if this has been updated in main
| static byte[] GetEncryptionKey(string encryptionPassword) | ||
| { | ||
| #if NET8_0_OR_GREATER | ||
| using var passwordGenerator = new Rfc2898DeriveBytes(encryptionPassword, PasswordPaddingSalt, PasswordSaltIterations, HashAlgorithmName.SHA1); |
There was a problem hiding this comment.
NET8 requires the encryption algorithm is explicit as the other overload has been marked as obsolete.
Internally, it used the SHA1 algorithm.
| #endif | ||
| } | ||
|
|
||
| #if NET6_0_OR_GREATER |
There was a problem hiding this comment.
Check if this should be NET8_0_OR_GREATER instead
|
We reviewed this work as a mob. |
Background
With the EOL of .NET 6 coming in November, this PR sets up Tentacle to build versions targeting .NET 8.
Results
resolves #999
How to review this PR
Quality ✔️
Pre-requisites