Skip to content

Conversation

mwalling-dc
Copy link
Contributor

@mwalling-dc mwalling-dc commented Aug 22, 2024

Background

#46 added the --proxy CLI arg. This change adds the ability to pass the value for that token as an environment variable into the container.

Results

After

Specifying ProxyName as an environment variable to the container will add it as the value of the --proxy CLI flag.

Testing

This has been running in production for approximately a year. We're trying to unwind our customizations on top of the upstream image.

@mwalling-dc mwalling-dc requested a review from a team as a code owner August 22, 2024 19:39
@CLAassistant
Copy link

CLAassistant commented Aug 22, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@rhysparry rhysparry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR. With some minor changes we should be able to approve.

Could you please add details of any testing you might have done to your PR description?

Many thanks

@mwalling-dc mwalling-dc requested a review from rhysparry August 27, 2024 20:03
Copy link
Contributor

@rhysparry rhysparry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the contribution.

@rhysparry rhysparry merged commit f162e94 into OctopusDeploy:main Aug 28, 2024
@rhysparry
Copy link
Contributor

Thanks again. This change is available from version 8.1.2115 onwards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proxy configuration support in Docker images

3 participants