Makes --proxy added in #46 available to Docker containers #995
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
#46 added the
--proxy
CLI arg. This change adds the ability to pass the value for that token as an environment variable into the container.Results
After
Specifying
ProxyName
as an environment variable to the container will add it as the value of the--proxy
CLI flag.Testing
This has been running in production for approximately a year. We're trying to unwind our customizations on top of the upstream image.