Skip to content

Remove automatic suffix to Truncate function #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove automatic suffix to Truncate function #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
359350b
Remove automatic suffix to Truncate function
APErebus Jun 20, 2024
62c39b6
Fix formatting
APErebus Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion source/Octostache.Tests/FiltersFixture.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -643,7 +643,16 @@ public void TruncateHandlesNegativeLength()
public void TruncateTruncatesArgumentToSpecifiedLength()
{
var result = Evaluate(@"#{foo | Truncate 7}", new Dictionary<string, string> { { "foo", "Octopus Deploy" } });
result.Should().Be("Octopus...");
result.Should().Be("Octopus");
result.Should().HaveLength(7);
}

[Fact]
public void TruncateTruncatesArgumentToSpecifiedLengthWithCustomSuffix()
{
var result = Evaluate(@"#{foo | Truncate 7 ""<|>""}", new Dictionary<string, string> { { "foo", "Octopus Deploy" } });
result.Should().Be("Octopus<|>");
result.Should().HaveLength(10);
}

[Fact]
Expand Down
3 changes: 2 additions & 1 deletion source/Octostache/Templates/Functions/TextManipulationFunction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,8 +118,9 @@ class TextManipulationFunction
}

var length = int.Parse(options[0]);
var suffix = options.Length == 2 ? options[1] : null;
return length < argument.Length
? $"{argument.Substring(0, length)}..."
? $"{argument.Substring(0, length)}{suffix}"
: argument;
}

Expand Down