Skip to content

Conversation

Astabh
Copy link

@Astabh Astabh commented Sep 12, 2025

The main Octopus chart already supports external secrets via the createSecrets flag - this PR adds the same capability to the MSSQL subchart.

Currently, users wanting to use external secrets management can do so for the main Octopus application secrets, but the MSSQL subchart always creates its own internal secret for the sa user. This creates inconsistency and prevents full external secrets management.

  • Added createSecrets flag to mssql subchart for consistency with main chart.
  • Added conditional secret creation in charts/mssql/templates/secret.yaml.
  • Amended the SA_PASSWORD env var reference in charts/mssql/templates/statefulset.yaml to support both internal and external secrets.
  • Added an init container to charts/octopus-deploy/templates/statefulset.yaml for dynamic database connection string construction when using external secret for the SA password.
  • Updated charts/octopus-deploy/values.yaml with mssql external secrets configuration options and documentation.
  • Added an external secrets section to README.md

@Astabh Astabh requested a review from a team as a code owner September 12, 2025 13:28
Copy link

changeset-bot bot commented Sep 12, 2025

⚠️ No Changeset found

Latest commit: 2e5ec62

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Sep 12, 2025

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants