feat: add DeletePackagesAssociatedWithReleases property #15
Conversation
| Computed: true, | ||
| }, | ||
| "delete_packages_associated_with_releases": datasourceSchema.BoolAttribute{ | ||
| Description: "When true, Octopus does not need to keep packages used by releases and runbook runs on the dashboard.", |
There was a problem hiding this comment.
Octopus is keeping releases and runbook runs that are on the dashboard. Maybe check out the docs that Susan is writing for some wording inspiration: OctopusDeploy/docs#2731
There was a problem hiding this comment.
nice catch with this! That would have been misleading
There was a problem hiding this comment.
This is what I have:
When true, a package which is not associated with a dashboard release or runback run will be deleted after the delete_unreleased_packages_after_days is exceeded.
I'm now wondering if the name: delete_unreleased_packages_after_days is misleading and should be changed to something more generically about package retention.
There was a problem hiding this comment.
When true, a package which is not associated with a dashboard release or runback run will be deleted after the delete_unreleased_packages_after_days is exceeded.
Nice, this looks more accurate. Remember that feeds.md also has a description.
I'm now wondering if the name: delete_unreleased_packages_after_days is misleading and should be changed to something more generically about package retention.
It could have a better name. Renaming the existing property would be a breaking change.
There was a problem hiding this comment.
We discussed this and agreed to change the description of delete_unreleased_packages_after_days to add clarity to this property without creating a breaking change.
Rose-Northey
changed the title
Rose-Northey
deleted the
rosen/add-DeletePackagesAssociatedWithReleases-property
branch
Background
On an octopus server PR a new property was added to enable users to delete packages while still saving releases - DeletePackagesAssociatedWithReleases.
This property was added to the go client. Here we add theDeletePackagesAssociatedWithReleases to the terraform client as well.
[sc-112378]
How to review this PR
delete_packages_associated_with_releaseschanges to true.e.g.