Fix: timer leak in multilock test by replacing time.Tick with NewTicker #15834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

anim001k wants to merge 1 commit into OffchainLabs:develop from anim001k:patch-1

anim001k commented Oct 9, 2025

Problem

The test TestClean in async/multilock_test.go uses time.Tick() which creates an unstoppable ticker, leading to goroutine and timer leaks.

Solution

Replace time.Tick() with time.NewTicker()
Add defer ticker.Stop() to properly clean up resources
Update select case to use ticker.C channel


          Update multilock_test.go

CLAassistant commented Oct 9, 2025 •

edited

Loading

All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet