refactor: replace Split in loops with more efficient SplitSeq #15870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: asttool <asttool@outlook.com>
|
|
|
@rkapka @terencechain Hi, Could you please review this PR at your convenience? Thank you very much. |
|
We use strings.Split in 87 places. Could this be applied to all areas of the application or is there a reason to only change these three instances? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
Optimize code using a more modern writing style which can make the code more efficient and cleaner.
strings.SplitSeq(introduced in Go 1.23) returns a lazy sequence (strings.Seq), allowing gopher to iterate over tokens one by one without creating an intermediate slice.It significantly reduces memory allocations and can improve performance for long strings.
More info: golang/go#61901
Which issues(s) does this PR fix?
Fixes #
Other notes for review
Acknowledgements