Skip to content

Remove archived samples from CI build matrix and added TeamsSDK sample builds#1954

Merged
Harikrishnan-MSFT merged 15 commits into
mainfrom
v-hrajandira/CICDBuildPipeline
Apr 29, 2026
Merged

Remove archived samples from CI build matrix and added TeamsSDK sample builds#1954
Harikrishnan-MSFT merged 15 commits into
mainfrom
v-hrajandira/CICDBuildPipeline

Conversation

@Harikrishnan-MSFT
Copy link
Copy Markdown
Contributor

@Harikrishnan-MSFT Harikrishnan-MSFT commented Apr 9, 2026

PR Description:

Summary
This PR performs two sets of changes:

  1. Archived sample removal from CI — Removes individual GitHub Actions workflow files and build matrix entries in build-complete-samples.yml for samples planned for archival, across all applicable language targets (C#, Node.js).

  2. TeamsSDK sample build fixes — Fixes CI buildability for TeamsSDK Node.js and Python samples by adding missing tsconfig.json, build scripts, TypeScript devDependency, correcting python-dotenv version specifiers, and applying an optional chaining fix in bot-task-modules.

Changes

Archived samples removed from CI (~85 workflow files deleted):

  • Deleted individual .github/workflows/*.yml files for all archived samples (app-, bot-, graph-, meeting, msgext-, tab-, typeahead-*, etc.)
  • Removed corresponding entries from .github/workflows/build-complete-samples.yml

TeamsSDK sample fixes:

  • Added tsconfig.json (ES2022/Node16 config) to: bot-ai-messages, bot-attachments, bot-cards, bot-meetings, bot-message-extensions, bot-quickstart, bot-task-modules (Node.js)
  • Added "build": "tsc --build" script and typescript ~5.8.3 devDependency to the above package.json files
  • Fixed python-dotenv version specifier: >=1.0.*>=1.0 in Python pyproject.toml files
  • Added [tool.setuptools.packages.find] to bot-auth-quickstart and bot-task-modules Python projects
  • Fixed optional chaining: app.http.use(...)app.http?.use(...) in bot-task-modules/index.ts

No functional code changes to sample logic.

@Harikrishnan-MSFT Harikrishnan-MSFT changed the title Remove selected samples from build workflow across all language targets Remove archived samples from CI build matrix Apr 9, 2026
@Harikrishnan-MSFT Harikrishnan-MSFT changed the title Remove archived samples from CI build matrix Remove archived samples from CI build matrix and fix TeamsSDK sample builds Apr 15, 2026
@Harikrishnan-MSFT Harikrishnan-MSFT changed the title Remove archived samples from CI build matrix and fix TeamsSDK sample builds Remove archived samples from CI build matrix and added TeamsSDK sample builds Apr 15, 2026
@lilyydu
Copy link
Copy Markdown
Collaborator

lilyydu commented Apr 15, 2026

May have missed this but are we going to be adding new workflows for the new samples? And do we need to fix any configs for the C# samples (noticed these new changes only capture TS/PY)

@Harikrishnan-MSFT
Copy link
Copy Markdown
Contributor Author

May have missed this but are we going to be adding new workflows for the new samples? And do we need to fix any configs for the C# samples (noticed these new changes only capture TS/PY)

The existing workflow has been updated to include Teams SDK samples for all three languages.
Filename: build-complete-samples.yml

`
csharp -
image

NodeJS -
image

Python -
image

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this just ensure that the samples build correctly? wondering if we can incorporate dependabot to check for package versioning and perform the necessary updates also

Copy link
Copy Markdown
Contributor Author

@Harikrishnan-MSFT Harikrishnan-MSFT Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this just ensure that the samples build correctly? wondering if we can incorporate dependabot to check for package versioning and perform the necessary updates also

Yes @lilyydu, We plan to implement this concept in the next PR. We can merge this PR and open a new one for those changes.

@Harikrishnan-MSFT
Copy link
Copy Markdown
Contributor Author

@Harikrishnan-MSFT Harikrishnan-MSFT merged commit 3f606ce into main Apr 29, 2026
128 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants