Skip to content

Commit 0eb380b

Browse files
TatianaKaposOlimpiaZurek
authored andcommitted
Fix windows build of RectangleEdges (facebook#35516)
Summary: [PR: Avoid emitting mountitems for default values](facebook@56e9aa3) used a constexpr in a template, which windows is unable to compile since type at this point is incomplete. Once removed, windows is able to build again. Let me know if there's a better way to fix this! See [10072](microsoft/react-native-windows#10072) for windows error messages ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [General] [Fixed] - Remove constexpr from RectangleEdges.h Pull Request resolved: facebook#35516 Test Plan: Windows has forked this file and had the change for ~5 month, all tests pass on Windows side Reviewed By: javache Differential Revision: D41639514 Pulled By: rshest fbshipit-source-id: fbe595f71a7ab0accb7a76edf58ffb6aeef1ae96
1 parent b42ebde commit 0eb380b

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

ReactCommon/react/renderer/graphics/RectangleEdges.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ struct RectangleEdges {
4444
};
4545

4646
template <typename T>
47-
constexpr RectangleEdges<T> const RectangleEdges<T>::ZERO = {};
47+
RectangleEdges<T> const RectangleEdges<T>::ZERO = {};
4848

4949
template <typename T>
5050
RectangleEdges<T> operator+(

0 commit comments

Comments
 (0)