-
Notifications
You must be signed in to change notification settings - Fork 0
create vignette AE #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Up 😃
vignettes/ae_grade.Rmd
Outdated
|
||
Maximum AE grade per patient (for both single-arm and two-arm trials) | ||
|
||
All AE grades per patient (for both single-arm and two-arm trials) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"All AE grades" is not 100% accurate. See the documentation.
Also, I'm not sure how you should describe the tables, as there are so many, but 3 categories is not what I would have said, as there are still only 2 functions. Maybe you should focus on that first? E.g. "this vignette demonstrate how to use the 2 functions of grstat, xxx() and xxx()".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adverse Events by Maximum Grade per Patient (Grades 1–5, for both single-arm and two-arm trials)?
I am not quite sure what are you referring to after that?
vignettes/ae_grade.Rmd
Outdated
|
||
This vignette covers the following steps: | ||
|
||
Overview of the dataset, using the simulated dataset grstat_example |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use markdown throughout your vignette, otherwise it is not very comfortable to read.
It is fairly easy to learn and very useful in many cases. (remember, for the backtick ` on overcomplicated French keyboards, it is Alt Gr + 7, then space)
You can also use the "Visual" mode in RStudio if you don't want to learn.
vignettes/ae_grade.Rmd
Outdated
|
||
Overview of the dataset, using the simulated dataset grstat_example | ||
|
||
Creation of various AE tables for single-arm and two-arm trials, including subgroup analysis based on whether the AE is: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I'm following, is this a level-2 list?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just changed the format also there might be too many things and I might eventually remove some.
vignettes/ae_grade.Rmd
Outdated
add_footer_lines("Percentages reflect the proportion of patients presenting at most one AE of given grade") | ||
``` | ||
|
||
## Table of all grades per patient |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"All grades" is not really true.
You have to summarise the information at some point, otherwise, you need one row per patient.
I implemented 3 "variants" of summarisation.
If the documentation is unclear, we should improve it! (I struggled a lot to write it, I'm sure there is a lot of room for improvement.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made changes, please have a look. par contre question, pour la troisieme table, est ce que tu compte le patients 1 fois par grade ou plusieur fois pour le meme grade?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
t as pu regarder ce que j ai fait avant que je continue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go Livia go !
## Table of maximum grades per patient | ||
|
||
```{r} | ||
ae_table_grade(df_ae=ae, df_enrol=enrolres, arm=NULL, variant="max") %>% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
idem mais avec le défaut de variant : variant=c("max", "sup", "eq")
Ensuite bien expliquer la différence.
|
||
## Table of all grades per patient by arms | ||
|
||
```{r} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tu peux n'afficher que les n premières lignes pour raccourcir les tables si besoin
ae_table_soc(df_ae=ae, df_enrol=enrolres) %>% head(2) %>%
as_flextable()
No description provided.