Merge pull request #82 from OneBusAway/release-please--branches--main--changes--next

release: 1.0.0

Author: Ahmedhossamdev

.release-please-manifest.json

@@ -1,3 +1,3 @@
 {
-  ".": "0.1.0-alpha.24"
+  ".": "1.0.0"
 }

CHANGELOG.md

@@ -1,5 +1,13 @@
 # Changelog
 
+## 1.0.0 (2025-05-17)
+
+Full Changelog: [v0.1.0-alpha.24...v1.0.0](https://github.com/OneBusAway/go-sdk/compare/v0.1.0-alpha.24...v1.0.0)
+
+### Chores
+
+* **internal:** codegen related update ([681c135](https://github.com/OneBusAway/go-sdk/commit/681c135a5d30db41ce1f3abf8968e36314161d4b))
+
 ## 0.1.0-alpha.24 (2025-04-30)
 
 Full Changelog: [v0.1.0-alpha.23...v0.1.0-alpha.24](https://github.com/OneBusAway/go-sdk/compare/v0.1.0-alpha.23...v0.1.0-alpha.24)

README.md

@@ -24,7 +24,7 @@ Or to pin the version:
 <!-- x-release-please-start-version -->
 
 ```sh
-go get -u 'github.com/OneBusAway/go-sdk@v0.1.0-alpha.24'
+go get -u 'github.com/OneBusAway/go-sdk@v1.0.0'
 ```
 
 <!-- x-release-please-end -->

internal/requestconfig/requestconfig.go

@@ -208,6 +208,9 @@ type RequestConfig struct {
 	Context        context.Context
 	Request        *http.Request
 	BaseURL        *url.URL
+	// DefaultBaseURL will be used if BaseURL is not explicitly overridden using
+	// WithBaseURL.
+	DefaultBaseURL *url.URL
 	CustomHTTPDoer HTTPDoer
 	HTTPClient     *http.Client
 	Middlewares    []middleware
@@ -374,7 +377,11 @@ func retryDelay(res *http.Response, retryCount int) time.Duration {
 
 func (cfg *RequestConfig) Execute() (err error) {
 	if cfg.BaseURL == nil {
-		return fmt.Errorf("requestconfig: base url is not set")
+		if cfg.DefaultBaseURL != nil {
+			cfg.BaseURL = cfg.DefaultBaseURL
+		} else {
+			return fmt.Errorf("requestconfig: base url is not set")
+		}
 	}
 
 	cfg.Request.URL, err = cfg.BaseURL.Parse(strings.TrimLeft(cfg.Request.URL.String(), "/"))
@@ -508,6 +515,7 @@ func (cfg *RequestConfig) Execute() (err error) {
 	}
 
 	contents, err := io.ReadAll(res.Body)
+	res.Body.Close()
 	if err != nil {
 		return fmt.Errorf("error reading response body: %w", err)
 	}
@@ -607,3 +615,17 @@ func PreRequestOptions(opts ...RequestOption) (RequestConfig, error) {
 	}
 	return cfg, nil
 }
+
+// WithDefaultBaseURL returns a RequestOption that sets the client's default Base URL.
+// This is always overridden by setting a base URL with WithBaseURL.
+// WithBaseURL should be used instead of WithDefaultBaseURL except in internal code.
+func WithDefaultBaseURL(baseURL string) RequestOption {
+	u, err := url.Parse(baseURL)
+	return RequestOptionFunc(func(r *RequestConfig) error {
+		if err != nil {
+			return err
+		}
+		r.DefaultBaseURL = u
+		return nil
+	})
+}

internal/version.go

@@ -2,4 +2,4 @@
 
 package internal
 
-const PackageVersion = "0.1.0-alpha.24" // x-release-please-version
+const PackageVersion = "1.0.0" // x-release-please-version

option/requestoption.go

@@ -182,7 +182,6 @@ func WithJSONSet(key string, value interface{}) RequestOption {
 			if err != nil {
 				return err
 			}
-			return nil
 		} else {
 			return fmt.Errorf("cannot use WithJSONSet on a body that is not serialized as *bytes.Buffer")
 		}
@@ -263,7 +262,7 @@ func WithRequestTimeout(dur time.Duration) RequestOption {
 // environment to be the "production" environment. An environment specifies which base URL
 // to use by default.
 func WithEnvironmentProduction() RequestOption {
-	return WithBaseURL("https://api.pugetsound.onebusaway.org/")
+	return requestconfig.WithDefaultBaseURL("https://api.pugetsound.onebusaway.org/")
 }
 
 // WithAPIKey returns a RequestOption that sets the client setting "api_key".