Skip to content

Conversation

yashc18
Copy link

@yashc18 yashc18 commented Apr 9, 2025

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Apply the AndroidStyle.xml style template to your code in Android Studio.

  • Run the unit tests with gradlew connectedObaGoogleDebugAndroidTest to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them for the initial submission of the pull request. When addressing comments on a pull request, please push a new commit per comment when possible (reviewers will squash and merge using GitHub merge tool)

Fixes : #1426
This PR addresses the use of deprecated XML layout attributes throughout the codebase:

  • Replaces deprecated fill_parent with match_parent
  • Replaces deprecated android:singleLine="true" with android:maxLines="1"

@amrhossamdev amrhossamdev self-requested a review April 9, 2025 21:28
@amrhossamdev
Copy link
Member

Hi @yashc18. Thanks for your contributions. Can you tell me how you tested that?

@yashc18
Copy link
Author

yashc18 commented Apr 13, 2025

Hi @yashc18. Thanks for your contributions. Can you tell me how you tested that?

@amrhossamdev These changes are straightforward one-to-one replacements of equivalent attributes, so no behavioral changes are expected.

I performed the following testing after making the changes:

  • Built the application to verify it compiles successfully
  • Ran the app on an Android device to verify layouts render correctly
  • Tested specific screens with updated layouts to ensure proper appearance
  • Verified that functionality of all affected screens remained unchanged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace deprecated XML layout attributes across the app
2 participants