Adding Kiedybus rebranding flavour #1439
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @wkulesza can you figure out why tests fail? |
|
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds the KiedyBus rebranding flavour to the main repo so that a separate fork isn’t needed. The changes include new localized string resources, color themes, and updated build configuration for the KiedyBus variant.
- Added KiedyBus‑specific XML resource files for strings, colors, arrays, and non-translatable values.
- Updated google‑services.json with a new client configuration.
- Extended build.gradle to include a new flavor block for KiedyBus.
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| onebusaway-android/src/kiedybus/res/values/strings.xml | Adds KiedyBus string resources and tutorial text. |
| onebusaway-android/src/kiedybus/res/values/do_not_translate.xml | Provides non-translatable strings with updated endpoints. |
| onebusaway-android/src/kiedybus/res/values/colors.xml | Introduces a new color palette for KiedyBus. |
| onebusaway-android/src/kiedybus/res/values-pl/arrays.xml | Supplies Polish localized arrays and text for KiedyBus. |
| onebusaway-android/src/kiedybus/res/values-es/strings.xml | Supplies Spanish localized strings with KiedyBus branding. |
| onebusaway-android/google-services.json | Updates client configuration for the KiedyBus Android package. |
| onebusaway-android/build.gradle | Adds a new flavor block with build configurations for KiedyBus. |
Comments suppressed due to low confidence (2)
onebusaway-android/build.gradle:215
- The comment references 'Agency X' instead of KiedyBus. Please update it to reflect the new KiedyBus rebranding to avoid confusion.
// "Agency X" rebranding OneBusAway as another app - see src/agencyX/res for branded resources
onebusaway-android/src/kiedybus/res/values-es/strings.xml:26
- The word 'esta' should have an accent ('está') to correctly reflect Spanish spelling.
<string name="tutorial_arrival_header_arrival_info_text">¡Largo tiempo! El color de fondo te indica si el bus esta adelantado (rojo) o va atrasado (azul oscuro). Si es azul claro se encuentra a tiempo.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Well done @wkulesza can you verify that google maps works with the kiedy bus build ? it dosen't seem it works for me ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order not to have to fork the code for all changes in OBA Android, I would like to add KiedyBus as a rebranding flavour to the main repo. I hope I did that correctly, as i needed to add to build.gradle, to google-services.json, create new project with icons and provide more translations.