Skip to content

Add plausible analytics #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 17, 2025
Merged

Add plausible analytics #176

merged 8 commits into from
Feb 17, 2025

Conversation

Ahmedhossamdev
Copy link
Member

Fixes: #175

@Ahmedhossamdev Ahmedhossamdev self-assigned this Feb 16, 2025
@coveralls
Copy link

coveralls commented Feb 16, 2025 •
edited
Loading

Coverage Status

coverage: 11.598% (+2.1%) from 9.509%
when pulling c7c9bfe on feat/analytics
into 0bcb19c on main.

aaronbrethorst
aaronbrethorst requested changes Feb 16, 2025
View reviewed changes
Copy link
Member

@aaronbrethorst aaronbrethorst left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work! I'd like to see a couple small changes before we merge, but otherwise good to go!

One other item of note: please add some basic tests for the front-end Plausible client and the backend fetch() call to the Plausible server.

aaronbrethorst
aaronbrethorst approved these changes Feb 17, 2025
View reviewed changes
Copy link
Member

@aaronbrethorst aaronbrethorst left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work! 🔥

@aaronbrethorst aaronbrethorst merged commit 789d49e into main Feb 17, 2025
4 checks passed
@aaronbrethorst aaronbrethorst deleted the feat/analytics branch February 17, 2025 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronbrethorst aaronbrethorst aaronbrethorst approved these changes

Assignees

@Ahmedhossamdev Ahmedhossamdev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Analytics Support for WayFinder
3 participants
@Ahmedhossamdev @coveralls @aaronbrethorst