Skip to content

Conversation

iqbalcodes6602
Copy link
Contributor

added a check on view schedule button to contionally render it only when the tripselected variable is there

fixes: #192

@CLAassistant
Copy link

CLAassistant commented Feb 24, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! except that listing failed. please go back and run the linter.

@coveralls
Copy link

coveralls commented Mar 6, 2025

Coverage Status

coverage: 15.733% (-0.8%) from 16.487%
when pulling 2db1f37 on iqbalcodes6602:Don't-Show-View-Schedule
into 4220475 on OneBusAway:main.

Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@aaronbrethorst aaronbrethorst merged commit 9734339 into OneBusAway:main Mar 21, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't Show "View Schedule" on the standalone Arrivals and Departures page
4 participants