Skip to content

Conversation

ankitkumar748846
Copy link
Contributor

Fixed: #202

Description

This PR adds a favicon to the application to improve branding and user experience.

Screenshots

Screenshot from 2025-03-06 02-50-51

@ankitkumar748846
Copy link
Contributor Author

@aaronbrethorst

Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks but these won't work in production.

repro:

npm run build
npm run preview

open http://localhost:4173

image

@ankitkumar748846
Copy link
Contributor Author

@aaronbrethorst When I run npm run dev, the favicon appears correctly, but when I run npm run build followed by npm run preview, it does not. Do I need to add any configuration in svelte.config.js to fix this?

The static/ folder, which contains my favicon, is located outside of the src/ directory at the project root. It works fine in development but does not appear in the production build. Any suggestions?

@ankitkumar748846
Copy link
Contributor Author

@aaronbrethorst I have made the necessary changes to ensure the favicon loads correctly in production. Let me know if any further adjustments are needed.

Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, but please lint locally and include those changes

@coveralls
Copy link

coveralls commented Mar 9, 2025

Coverage Status

coverage: 15.69% (-0.05%) from 15.737%
when pulling f2e23d8 on ankitkumar748846:favicon
into c45f8fc on OneBusAway:main.

@ankitkumar748846
Copy link
Contributor Author

@aaronbrethorst I have resolved the linting issues and ensured that all necessary changes are formatted correctly. Let me know if anything else needs to be adjusted.

Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

@aaronbrethorst aaronbrethorst merged commit 67a45df into OneBusAway:main Mar 19, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞Bug : Missing Favicon in the Application
3 participants