-
Notifications
You must be signed in to change notification settings - Fork 29
fix: added missing favicon #203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aaronbrethorst When I run npm run dev, the favicon appears correctly, but when I run npm run build followed by npm run preview, it does not. Do I need to add any configuration in svelte.config.js to fix this? The static/ folder, which contains my favicon, is located outside of the src/ directory at the project root. It works fine in development but does not appear in the production build. Any suggestions? |
@aaronbrethorst I have made the necessary changes to ensure the favicon loads correctly in production. Let me know if any further adjustments are needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good, but please lint locally and include those changes
@aaronbrethorst I have resolved the linting issues and ensured that all necessary changes are formatted correctly. Let me know if anything else needs to be adjusted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thanks!
Fixed: #202
Description
This PR adds a favicon to the application to improve branding and user experience.
Screenshots