Skip to content

Improved Accessibility: Added labels to theme switcher #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2025
Merged

Improved Accessibility: Added labels to theme switcher #207

merged 1 commit into from
Mar 21, 2025

Conversation

0x3mr
Copy link
Contributor

@0x3mr 0x3mr commented Mar 9, 2025

Fix: #206

Changes

  • Increased website accessibility by 5% by adding aria-label="Toggle theme" to the checkbox input in ThemeSwitcher.svelte

Screenshot
image

@CLAassistant
Copy link

CLAassistant commented Mar 9, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

aaronbrethorst
aaronbrethorst approved these changes Mar 21, 2025
View reviewed changes
Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@aaronbrethorst aaronbrethorst merged commit c13b9b7 into OneBusAway:main Mar 21, 2025
3 checks passed
@coveralls
Copy link

Coverage Status

coverage: 15.701%. remained the same
when pulling 75f8deb on 0x3mr:main
into 0d64bc9 on OneBusAway:main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronbrethorst aaronbrethorst aaronbrethorst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Accessibility Improvement: Add labels to theme switcher
4 participants
@0x3mr @CLAassistant @coveralls @aaronbrethorst