Fix: Improve getDirectionFromOrientation function #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

ankitkumar748846 wants to merge 1 commit into OneBusAway:main from ankitkumar748846:reduce

Contributor

ankitkumar748846 commented Mar 17, 2025

Fixes: #212

Description:

Added an initial value to .reduce() to prevent errors.
Added a check for an empty DIRECTIONS array to return null safely.
Ensured cleaner and more reliable code execution.


          Fix: Improve getDirectionFromOrientation function

2a3a34a

Member

aaronbrethorst commented Mar 21, 2025

I think we have bigger problems if DIRECTIONS is somehow empty.

aaronbrethorst closed this

coveralls commented Mar 21, 2025

coverage: 15.682% (-0.02%) from 15.701%
when pulling 2a3a34a on ankitkumar748846:reduce
into 0d64bc9 on OneBusAway:main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet