Test for getCookie and minor code improvements #224
Conversation
|
|
.env.example
Outdated
|
|
||
|
|
||
| PUBLIC_NAV_BAR_LINKS={"Home": "/","About": "/about","Contact": "/contact","Fares & Tolls": "/fares-and-tolls"} | ||
| PUBLIC_NAV_BAR_LINKS='{"Home": "/","About": "/about","Contact": "/contact","Fares & Tolls": "/fares-and-tolls"}' |
There was a problem hiding this comment.
what prompted this change?
There was a problem hiding this comment.
Yeah well the change is not very related to what I was doing mainly but the syntax of the value of the variable seemed to be incorrect. The variable attempted to directly store a dictionary which i thought was not standard practice. If this change was not ideal however please advise me on how to go about it next time.
Thank You.
There was a problem hiding this comment.
please undo this change.
.env.example
Outdated
|
|
||
|
|
||
| PUBLIC_NAV_BAR_LINKS={"Home": "/","About": "/about","Contact": "/contact","Fares & Tolls": "/fares-and-tolls"} | ||
| PUBLIC_NAV_BAR_LINKS='{"Home": "/","About": "/about","Contact": "/contact","Fares & Tolls": "/fares-and-tolls"}' |
There was a problem hiding this comment.
please undo this change.
| PUBLIC_ANALYTICS_DOMAIN="" | ||
| PUBLIC_ANALYTICS_ENABLED=true | ||
| PUBLIC_ANALYTICS_API_HOS="" | ||
|
|
There was a problem hiding this comment.
In the future, please be sure to avoid including extra whitespace like this in a file that you've reverted your other changes in.
This request addresses two key improvements:
Added Test Coverage for
getCookie:getCookiefunction inlib/utils/user.js.Improved Code Clarity in
lib/utils/user.js: