Skip to content

Test for getCookie and minor code improvements #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 27, 2025
Merged

Test for getCookie and minor code improvements #224

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
13b5dcf
test for getCookie
shark121 Mar 24, 2025
a19d9aa
env file correction
shark121 Mar 24, 2025
5fd03d9
set jsdom as devDependency, removed whitespace only lines
shark121 Mar 24, 2025
64cab0e
tests for getUserId and minor .env file changes
shark121 Mar 24, 2025
36b95bc
run linter
shark121 Mar 25, 2025
add8951
removed .env modification
shark121 Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .env.example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ PRIVATE_OBACO_SHOW_TEST_ALERTS=false



PUBLIC_NAV_BAR_LINKS={"Home": "/","About": "/about","Contact": "/contact","Fares & Tolls": "/fares-and-tolls"}
PUBLIC_NAV_BAR_LINKS='{"Home": "/","About": "/about","Contact": "/contact","Fares & Tolls": "/fares-and-tolls"}'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what prompted this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah well the change is not very related to what I was doing mainly but the syntax of the value of the variable seemed to be incorrect. The variable attempted to directly store a dictionary which i thought was not standard practice. If this change was not ideal however please advise me on how to go about it next time.
Thank You.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please undo this change.

PUBLIC_OBA_GOOGLE_MAPS_API_KEY=""
PUBLIC_OBA_LOGO_URL="https://onebusaway.org/wp-content/uploads/oba_logo-1.png"
PUBLIC_OBA_MAP_PROVIDER="osm"
Expand All @@ -25,4 +25,4 @@ PUBLIC_OTP_SERVER_URL=""
# Analytics
PUBLIC_ANALYTICS_DOMAIN=""
PUBLIC_ANALYTICS_ENABLED=true
PUBLIC_ANALYTICS_API_HOS=""
PUBLIC_ANALYTICS_API_HOS=""
Loading