Manage modals in single bit of state #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronbrethorst
requested changes
Mar 27, 2025
No big deal, right? 😅 Sorry, was planning on taking another pass through this before formally requesting review (does it auto-request when you open a PR?) Anyway, is there a public OTP endpoint or guidance on how to set it up locally (I could probably sort this without it, but curious regardless). Thanks! |
|
@bencodeorg I slacked you the necessary info |
|
Alrighty @aaronbrethorst, should be sorted now (was a typo, switched to use a constant to manage the modal states rather than individual strings to hopefully avoid in the future). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A proposed organizational improvement to managing the modal in the side panel -- namely, using a single bit of state to choose which modal to show, rather than a series of booleans.