Skip to content

Conversation

bencodeorg
Copy link
Contributor

I noticed that trip endpoints and routes can get out of whack when changing the start or end location of a route. For example, I saw the following as I chose different start/end locations:

image

This is slightly a product-y choice, but this change makes it so that the start/stop locations on the map are only updated when you actually click the "Plan Your Trip" button. This seemed sensible since the routes shown (ie, "Itinerary 1", "Itinerary 2", etc.) represent the points on the map that were selected when you last clicked the "Plan Your Trip" button.

There's also a slight timing tweak here to only render the new start/stop locations once we've received the new route from the API, such that the route and the start/stop locations change at the same time.

@coveralls
Copy link

coveralls commented Apr 1, 2025

Coverage Status

coverage: 16.117% (+0.02%) from 16.097%
when pulling c2df0d7 on bencodeorg:ben/trip-planner-handle-start-stop-update
into d4b0cd3 on OneBusAway:main.

@bencodeorg
Copy link
Contributor Author

@aaronbrethorst I think this is ready for review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants