Only update trip planner route and endpoints on plan button click #235
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that trip endpoints and routes can get out of whack when changing the start or end location of a route. For example, I saw the following as I chose different start/end locations:
This is slightly a product-y choice, but this change makes it so that the start/stop locations on the map are only updated when you actually click the "Plan Your Trip" button. This seemed sensible since the routes shown (ie, "Itinerary 1", "Itinerary 2", etc.) represent the points on the map that were selected when you last clicked the "Plan Your Trip" button.
There's also a slight timing tweak here to only render the new start/stop locations once we've received the new route from the API, such that the route and the start/stop locations change at the same time.